Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44429 )
Change subject: util: Add spd_tools to generate DDR4 SPDs for TGL boards
......................................................................
Patch Set 29:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44429/28/util/spd_tools/intel/ddr4/...
File util/spd_tools/intel/ddr4/gen_spd.go:
https://review.coreboot.org/c/coreboot/+/44429/28/util/spd_tools/intel/ddr4/...
PS28, Line 476: tRRDLFromTck = 4 * memAttribs.TCKMinPs
:
: if tRRDLFixed < tRRDLFromTck {
: return tRRDLFromTck
: } else {
: return tRRDLFixed
: }
:
Yeah I think if there is an override present, we will want to honor that. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44429
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I263f936b332520753a6791c8d892fc148cb6f103
Gerrit-Change-Number: 44429
Gerrit-PatchSet: 29
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Aug 2020 21:01:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment