Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )
Change subject: security/vboot: Add vboot callbacks to support EC software sync
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36208/13/src/security/vboot/ec_sync...
File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/36208/13/src/security/vboot/ec_sync...
PS13, Line 64: ctx.flags |= VB2_CONTEXT_EC_SYNC_SUPPORTED;
Probably need static initialization of ctx, so that flags don't contain unexpected flags set.
The initialization of all of the context, etc. will change once Joel gets the persistent vboot context work done. This patch is blocked on those changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b1458a45ab3ed5623af50f78036c4f88461b226
Gerrit-Change-Number: 36208
Gerrit-PatchSet: 13
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 31 Oct 2019 15:49:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment