Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )
Change subject: security/vboot: Add vboot callbacks to support EC software sync
......................................................................
Patch Set 19:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36208/19/src/security/vboot/ec_sync...
File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/36208/19/src/security/vboot/ec_sync...
PS19, Line 73: x
%#x
https://review.coreboot.org/c/coreboot/+/36208/19/src/security/vboot/ec_sync...
PS19, Line 73: Software sync on EC
EC software sync
https://review.coreboot.org/c/coreboot/+/36208/19/src/security/vboot/ec_sync...
PS19, Line 75: /* TODO: vboot persistent context */
: vboot_finalize_work_context(&ctx);
Note that this can just be removed after persistent context is merged.
https://review.coreboot.org/c/coreboot/+/36208/19/src/security/vboot/vboot_c...
File src/security/vboot/vboot_common.h:
https://review.coreboot.org/c/coreboot/+/36208/19/src/security/vboot/vboot_c...
PS19, Line 91: VBERROR_
VB2_ERROR_*
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b1458a45ab3ed5623af50f78036c4f88461b226
Gerrit-Change-Number: 36208
Gerrit-PatchSet: 19
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 Nov 2019 14:09:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment