Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31599 )
Change subject: mb/google/hatch: Initialize GPIO_PCH_WP early in boot ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31599/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31599/3/src/mainboard/google/hatch/variants/... PS3, Line 212: /* PCH_WP_OD */ : PAD_CFG_GPI(GPP_C20, NONE, DEEP), Can you please place this before GPP_C21?
Also, this should be placed in gpio_table as well.
https://review.coreboot.org/#/c/31599/3/src/mainboard/google/hatch/variants/... PS3, Line 223: CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), There is no mention in commit message of this change.