Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47512 )
Change subject: nb/intel/sandybridge: Use bitfields to program MCMAIN timings
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit_common.h:
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy...
PS7, Line 165: [12..12]
i'd use [12] here instead; some more instances above and below. should be fixed in a follow-up patch to avoid rebases
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47512
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a996de5d596cdb541c8b327f119425243724007
Gerrit-Change-Number: 47512
Gerrit-PatchSet: 7
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 22 Nov 2020 19:54:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment