Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29638 )
Change subject: SMBIOS: Remove duplicated smbios_memory_type enum ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/29638/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29638/2//COMMIT_MSG@9 PS2, Line 9: memory_speed I would prefer mem_clock_frequency or mem_clk_freq. Something that clearly says memory clock frequency. clock_frequency would be acceptable too. Unless this defines transfer rate instead of clock (DDR has 2 transfers per clock cycle for example). Only then would memory_speed be acceptable.
https://review.coreboot.org/#/c/29638/2/src/include/smbios.h File src/include/smbios.h:
https://review.coreboot.org/#/c/29638/2/src/include/smbios.h@a122 PS2, Line 122: : : : : : These memory types are not present at smbios_memory_type enum. They need to go there (renamed).