build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31474 )
Change subject: vboot: standardize on working data size
......................................................................
Patch Set 14:
(4 comments)
https://review.coreboot.org/#/c/31474/14/src/include/memlayout.h
File src/include/memlayout.h:
https://review.coreboot.org/#/c/31474/14/src/include/memlayout.h@163
PS14, Line 163: #define VBOOT2_WORK(addr, sz) \
Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/#/c/31474/14/src/include/memlayout.h@163
PS14, Line 163: #define VBOOT2_WORK(addr, sz) \
macros should not use a trailing semicolon
https://review.coreboot.org/#/c/31474/14/src/include/memlayout.h@167
PS14, Line 167: VB2_FIRMWARE_WORKBUF_RECOMMENDED_SIZE! (sz)));
space required before that '!' (ctx:VxW)
https://review.coreboot.org/#/c/31474/14/src/include/memlayout.h@167
PS14, Line 167: VB2_FIRMWARE_WORKBUF_RECOMMENDED_SIZE! (sz)));
space prohibited after that '!' (ctx:VxW)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31474
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id71a8ab2401efcc0194d48c8af9017fc90513cb8
Gerrit-Change-Number: 31474
Gerrit-PatchSet: 14
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Randall Spangler
rspangler@google.com
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 21 Mar 2019 16:16:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment