Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42798 )
Change subject: drivers/mrc_cache: Avoid unused variable assignment ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42798/1/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/42798/1/src/drivers/mrc_cache/mrc_c... PS1, Line 456: boot_device_spi_flash
You mean, in case the two if statements above are true?
No. Previously, every call to "nvm_protect" would call `boot_device_spi_flash`. Now, calls to "nvm_protect" will only call "boot_device_spi_flash" if the two checks are false. Would be good to know if this makes any difference.