[coreboot-gerrit] Change in coreboot[master]: mb/starlabs/labtop: Add enum for `power_profile`

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60212 )

Change subject: mb/starlabs/labtop: Add enum for `power_profile`
......................................................................

mb/starlabs/labtop: Add enum for `power_profile`

Introduce and use an enum for the `power_profile` CMOS option. Add a
helper function that converts CMOS values into enum values. Using an
enum allows GCC to warn about switch statements using enum types for
their control expressions not handling all possible enum values, and
also improves readability.

Change-Id: I47a453ea12d164d26908a9944a89a481757e753c
Signed-off-by: Angel Pons 
---
M src/mainboard/starlabs/labtop/include/variants.h
M src/mainboard/starlabs/labtop/mainboard.c
M src/mainboard/starlabs/labtop/variants/tgl/devtree.c
3 files changed, 29 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/60212/1

diff --git a/src/mainboard/starlabs/labtop/include/variants.h b/src/mainboard/starlabs/labtop/include/variants.h
index c95d15b..0dd41c0 100644
--- a/src/mainboard/starlabs/labtop/include/variants.h
+++ b/src/mainboard/starlabs/labtop/include/variants.h
@@ -5,6 +5,15 @@

#include <soc/gpio.h>

+enum cmos_power_profile {
+	PP_POWER_SAVER = 0,
+	PP_BALANCED    = 1,
+	PP_PERFORMANCE = 2,
+};
+#define NUM_POWER_PROFILES 3
+
+enum cmos_power_profile get_power_profile(enum cmos_power_profile fallback);
+
 /*
  * The next set of functions return the gpio table and fill in the number of
  * entries for each table.
diff --git a/src/mainboard/starlabs/labtop/mainboard.c b/src/mainboard/starlabs/labtop/mainboard.c
index 60e65ee..d394f25 100644
--- a/src/mainboard/starlabs/labtop/mainboard.c
+++ b/src/mainboard/starlabs/labtop/mainboard.c
@@ -5,6 +5,12 @@
 #include <option.h>
 #include <variants.h>

+enum cmos_power_profile get_power_profile(enum cmos_power_profile fallback)
+{
+	const unsigned int power_profile = get_uint_option("power_profile", fallback);
+	return power_profile < NUM_POWER_PROFILES ? power_profile : fallback;
+}
+
 static void init_mainboard(void *chip_info)
 {
    const struct pad_config *pads;
diff --git a/src/mainboard/starlabs/labtop/variants/tgl/devtree.c b/src/mainboard/starlabs/labtop/variants/tgl/devtree.c
index 42a5aff..09d26e8 100644
--- a/src/mainboard/starlabs/labtop/variants/tgl/devtree.c
+++ b/src/mainboard/starlabs/labtop/variants/tgl/devtree.c
@@ -24,26 +24,26 @@

/* Update PL1 & PL2 based on CMOS settings */
-	switch (get_uint_option("power_profile", 0)) {
-	case 1:
-		soc_conf_2core->tdp_pl1_override = 15;
-		soc_conf_4core->tdp_pl1_override = 15;
-		soc_conf_2core->tdp_pl2_override = 25;
-		soc_conf_4core->tdp_pl2_override = 25;
-		break;
-	case 2:
-		soc_conf_2core->tdp_pl1_override = 28;
-		soc_conf_4core->tdp_pl1_override = 28;
-		soc_conf_2core->tdp_pl2_override = 40;
-		soc_conf_4core->tdp_pl2_override = 40;
-		break;
-	default:
+	switch (get_power_profile(PP_POWER_SAVER)) {
+	case PP_POWER_SAVER:
    	disable_turbo();
    	soc_conf_2core->tdp_pl1_override = 15;
    	soc_conf_4core->tdp_pl1_override = 15;
    	soc_conf_2core->tdp_pl2_override = 15;
    	soc_conf_4core->tdp_pl2_override = 15;
    	break;
+	case PP_BALANCED:
+		soc_conf_2core->tdp_pl1_override = 15;
+		soc_conf_4core->tdp_pl1_override = 15;
+		soc_conf_2core->tdp_pl2_override = 25;
+		soc_conf_4core->tdp_pl2_override = 25;
+		break;
+	case PP_PERFORMANCE:
+		soc_conf_2core->tdp_pl1_override = 28;
+		soc_conf_4core->tdp_pl1_override = 28;
+		soc_conf_2core->tdp_pl2_override = 40;
+		soc_conf_4core->tdp_pl2_override = 40;
+		break;
    }

/* Enable/Disable Wireless based on CMOS settings */