Attention is currently required from: Hung-Te Lin, Jarried Lin, Xi Chen.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83937?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek: Refactor mmu operation for L2C SRAM and DMA ......................................................................
Patch Set 2:
(3 comments)
File src/soc/mediatek/common/l2c_ops.c:
https://review.coreboot.org/c/coreboot/+/83937/comment/523e409a_94e363d3?usp... : PS2, Line 15: MP0_CLUSTER_CFG0_L3_SHARE_EN, 0); alignment
https://review.coreboot.org/c/coreboot/+/83937/comment/224c0dad_0333b243?usp... : PS2, Line 28: MP0_CLUSTER_CFG0_L3_SHARE_PRE_EN, 0); alignment
File src/soc/mediatek/mt8186/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83937/comment/490cb70f_75155c43?usp... : PS2, Line 28: ../common/l2c_ops.c Can we put it in its own line? Same below.