Attention is currently required from: Christian Walter, Johnny Lin, Lean Sheng Tan, Naresh Solanki, Shuo Liu, Tim Chu.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80666?usp=email )
Change subject: soc/intel/xeon_sp/spr: Set _STA for each IIO stack ......................................................................
Patch Set 1: Code-Review-1
(8 comments)
Patchset:
PS1: I'm sad to see such code, please do better.
File src/soc/intel/xeon_sp/spr/acpi/cxl_resource.asl:
https://review.coreboot.org/c/coreboot/+/80666/comment/6115cb4b_df219585 : PS1, Line 23: STPREFIX STPREFIX is now unused
File src/soc/intel/xeon_sp/spr/soc_acpi.c:
https://review.coreboot.org/c/coreboot/+/80666/comment/573a8e52_e283696d : PS1, Line 71: acpigen_write_STA Must not write _STA here, only _CRS.
https://review.coreboot.org/c/coreboot/+/80666/comment/7e775788_b9f15ea9 : PS1, Line 158: stack needs explanation
https://review.coreboot.org/c/coreboot/+/80666/comment/323a4963_10073158 : PS1, Line 281: acpigen_write_STA Must not write _STA here, only _CRS.
https://review.coreboot.org/c/coreboot/+/80666/comment/d37a500e_ce0e1586 : PS1, Line 292: 0xf Magic numbers used.
https://review.coreboot.org/c/coreboot/+/80666/comment/6ed729fd_3d1c28c1 : PS1, Line 292: acpigen_write_STA Must not write _STA here, only _CRS.
https://review.coreboot.org/c/coreboot/+/80666/comment/e0deb84c_3deb9e7f : PS1, Line 354: create_dsdt_stack_sta Is now unused. Why isn't this function used to generate _STA in the right scope?