Attention is currently required from: Subrata Banik, Selma Bensaid, Tim Wawrzynczak, Paul Menzel, Sridhar Siricilla, Julius Werner, Patrick Rudolph.
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59507 )
Change subject: soc/intel/alderlake: Inject CSE TS into CBMEM timestamp table
......................................................................
Patch Set 16:
(2 comments)
File src/soc/intel/common/block/cse/telemetry.c:
https://review.coreboot.org/c/coreboot/+/59507/comment/cf40c213_3d6717b8
PS16, Line 13: s64
nit: […]
replied in the other one.
https://review.coreboot.org/c/coreboot/+/59507/comment/3710a9df_0eee66db
PS16, Line 37: (s64)
why signed? could there be "negative" timestamps?
no negative timestamps but start_stamp in the below operation can result in start_stamp being negative, that is a valid case. Type casting to s64 before subtraction. I think this is correct.
start_stamp = current_time - ts[PERF_DATA_CSME_GET_PERF_RESPONSE];
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59507
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcdbb69538ca2977cd97ce1ef9b211ff6510a3f8
Gerrit-Change-Number: 59507
Gerrit-PatchSet: 16
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 09 Feb 2022 18:19:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment