Attention is currently required from: Shelley Chen.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63289 )
Change subject: soc/qualcomm/common: Add strict flag to clock_configure()
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/soc/qualcomm/sc7180/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/5c7adb1b_aa3a1a33
PS4, Line 218: &mdss_clk_cfg, 0, 0, false);
I think that if it's the case that we're going to universally look for exact matches, then we should […]
Sure that works too, just make sure it die()s or something when running over the end of the array.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63289
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cfad7236241f4d03ff1a56683654649658b68fc
Gerrit-Change-Number: 63289
Gerrit-PatchSet: 5
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Comment-Date: Sat, 02 Apr 2022 01:08:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment