[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Generate ACPI pstate and cstate objects in cb

[Jason Glenesk (Code Review)]

Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45340 )

Change subject: soc/amd/picasso: Generate ACPI pstate and cstate objects in cb
......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45340/10/src/include/cpu/amd/msr.h 
File src/include/cpu/amd/msr.h:

https://review.coreboot.org/c/coreboot/+/45340/10/src/include/cpu/amd/msr.h@... 
PS10, Line 34: 7
> Isn't this 16 since the field is 4 bits wide?

max and current are 3 bits [6:4]maxval [2:0] curpstate in 0xC0010061

https://review.coreboot.org/c/coreboot/+/45340/10/src/soc/amd/picasso/acpi.c 
File src/soc/amd/picasso/acpi.c:

https://review.coreboot.org/c/coreboot/+/45340/10/src/soc/amd/picasso/acpi.c... 
PS10, Line 256: 0x3
> Define a macro for this. Also, this is 4-bit field.

This field is 3 bits [6:4]. I can define a macro for a mask and then shift.