[coreboot-gerrit] [S] Change in coreboot[main]: src/lib/malloc.c: If allocation fails, leave the heap unchanged

[Nico Huber (Code Review)]

Attention is currently required from: Eric Lai, Felix Held, Jonathon Hall, Julius Werner, Martin L Roth, Patrick Georgi.

Nico Huber has posted comments on this change by Jonathon Hall. ( https://review.coreboot.org/c/coreboot/+/83475?usp=email )

Change subject: src/lib/malloc.c: If allocation fails, leave the heap unchanged
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

File src/lib/malloc.c:

https://review.coreboot.org/c/coreboot/+/83475/comment/0dc23f42_adc90521?usp... :
PS1, Line 29: unsigned long
`(uintptr_t)`, which is technically the same for our targets, would make the intention clearer.

https://review.coreboot.org/c/coreboot/+/83475/comment/7cfc7264_729a73dc?usp... :
PS1, Line 34: 		printk(BIOS_ERR, "Tried to round up free_mem_ptr %p to %p\n",
            : 				free_mem_ptr, p);
I think the message text just didn't make sense, the printed numbers did though.
Because it was the new `free_mem_ptr` (now `p + size`) that conflicted with
`free_mem_end_ptr`. With the current PS you could get prints like
```
Tried to round up free_mem_ptr 0x1234 to 0x1300 but free_mem_end_ptr is 0x2000
```

```suggestion
    	printk(BIOS_ERR, "Tried to increase free_mem_ptr %p to %p\n",
    			free_mem_ptr, p + size);
```