Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48096 )
Change subject: drivers/ipmi: implement "POST complete" notification functionality
......................................................................
Patch Set 43:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48096/41/src/drivers/ipmi/chip.h
File src/drivers/ipmi/chip.h:
https://review.coreboot.org/c/coreboot/+/48096/41/src/drivers/ipmi/chip.h@26
PS41, Line 26: u16
or u32 at least ;)
already done and also updated the invert to bool, see latest patchset :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48096
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34764858be9c7f7f1110ce885fa056591164f148
Gerrit-Change-Number: 48096
Gerrit-PatchSet: 43
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Javier Galindo
javiergalindo@sysproconsulting.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 28 Dec 2020 23:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment