Attention is currently required from: Furquan Shaikh, Jack Rosenthal. Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56883 )
Change subject: elogtool: add "clear" command ......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS2: fixed missing files. PTAL, ty!
File src/commonlib/bsd/elog.c:
https://review.coreboot.org/c/coreboot/+/56883/comment/3508c4f1_842c0e35 PS2, Line 79: void elog_update_checksum(struct event_header *event, uint8_t checksum) : { : uint8_t *event_data = (uint8_t *)event; : event_data[event->length - 1] = checksum; : } assuming that the two checksum functions where created by Googler's and it is Ok to relicense them under BSD.
File util/cbfstool/elogtool.c:
https://review.coreboot.org/c/coreboot/+/56883/comment/f5fa5947_ef24c40f PS1, Line 127: void* data_offset;
"foo* bar" should be "foo *bar"
Please fix.
File util/cbfstool/eventlog.h:
https://review.coreboot.org/c/coreboot/+/56883/comment/163a0d7f_fc105a0d PS1, Line 11: void eventlog_init_event(struct event_header* event, uint8_t type,
"foo* bar" should be "foo *bar"
Please fix.