Sricharan Ramabadhran has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29970 )
Change subject: Mistral: QCS405: Added RPM support
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/#/c/29970/14/src/soc/qualcomm/qcs405/Makefile.in...
File src/soc/qualcomm/qcs405/Makefile.inc:
https://review.coreboot.org/#/c/29970/14/src/soc/qualcomm/qcs405/Makefile.in...
PS14, Line 61: ifneq (,$(findstring $(RPM_FILE),$(rpm_file)))
This is a hack, I don't not think we should submit any code like this. […]
Ok, will follow it up internally and come back on this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29970
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17f491f0a4bd0dce7522b7e80e1bac97ec18b945
Gerrit-Change-Number: 29970
Gerrit-PatchSet: 14
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sricharan Ramabadhran
srichara@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Fri, 08 Mar 2019 12:34:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment