[coreboot-gerrit] Change in coreboot[master]: src/drivers/intel/fsp2_0: allow larger FSP 2.0 header

[Martin Roth (Code Review)]

Attention is currently required from: Furquan Shaikh, Marshall Dawson, Subrata Banik, Nikolai Vyssotski, Andrey Petrov, Patrick Rudolph, Nathaniel L Desimone.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56190 )

Change subject: src/drivers/intel/fsp2_0: allow larger FSP 2.0 header
......................................................................

Patch Set 3:

(1 comment)

File src/drivers/intel/fsp2_0/include/fsp/info_header.h:

https://review.coreboot.org/c/coreboot/+/56190/comment/f8dd8008_dbbdba35 
PS2, Line 13:  however, some FSP 2.0 variants have it as well.
> Re: less desirable approach.  […]

The FSP header has a length field.  If the length is actually specified as a fixed length by the header version, this field is redundant.

My opinion is that the header fields are defined by the header version, however the length is not - it's specified by the length field.

I don't think we should have the header length hardcoded, and should instead rely on that length field (to a reasonable value), even if it's longer than the structure we're using.  Just treat anything past the end of the structure as reserved.