Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38247 )
Change subject: soc/intel/common/cse: Add consistent HECI command id/group id naming ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38247/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/38247/1/src/soc/intel/common/block/... PS1, Line 70: /* MKHI Command groups */ : #define MKHI_GROUP_ID_CBM 0x0 : #define MKHI_GROUP_ID_HMRFPO 0x5 : : /* Global Reset Command ID */ : #define MKHI_GLOBAL_RESET_REQ 0xb : : /* RST Origin */ : #define GR_ORIGIN_BIOS_POST 0x2 : : /* HMRFPO Command Ids */ : #define MKHI_HMRFPO_ENABLE 0x1 : #define MKHI_HMRFPO_GET_STATUS 0x3 : : /* ME Current Working States */ : #define ME_HFS1_CWS_NORMAL 0x5 : : /* ME Current Operation Modes */ : #define ME_HFS1_COM_NORMAL 0x0 : #define ME_HFS1_COM_SOFT_TEMP_DISABLE 0x3 : #define ME_HFS1_COM_SECOVER_MEI_MSG 0x5 What do you think about moving the MKHI group id/command id related macros to cse.h. I think in one of the later patches, there is a new group id/command id added to another .c file. It would be better to put all these in one place.