[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: fix use of legacy 8254 timer

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33512 )

Change subject: soc/intel/cannonlake: fix use of legacy 8254 timer
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/33512/1/src/soc/intel/cannonlake/fsp_params.... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/33512/1/src/soc/intel/cannonlake/fsp_params.... 
PS1, Line 249: 	params->Enable8254ClockGatingOnS3 = CONFIG_USE_LEGACY_8254_TIMER;
> given that it defaults to 1/enabled in FSP, is there a need to explicitly set it?

Yes, we don't know if the binary has been altered.