Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36924 )
Change subject: lib/fmap: Allow disabling all output in fmap cache ......................................................................
Patch Set 1:
Patch Set 1:
This seems a bit too specific to remove only these messages and no others if you ask me. I think either the platform should select NO_BOOTBLOCK_CONSOLE or NO_FMAP_CACHE (CB:36937).
Thanks, I'll adapt the following CL to use NO_FMAP_CACHE.
Yeah, that's also something we should really fix at some point I think, it would be much better than disabling consoles all-or-nothing.
The background is that we supported that for a long time, routing printk through a bunch of macros to eliminate extraneous strings. We dropped it at some point because it confused people that they couldn't crank up the loglevel in CMOS (or whereever they configured it) and see more log information. See http://review.coreboot.org/3188