[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/meteorlake: Replace assert with error message

[Kapil Porwal (Code Review)]

Attention is currently required from: Tarun Tuli, Subrata Banik, Eric Lai.

Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74370 )

Change subject: soc/intel/meteorlake: Replace assert with error message
......................................................................

Patch Set 3:

(2 comments)

File src/soc/intel/meteorlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/74370/comment/b9fade46_0a190d39 
PS2, Line 563: 	/* CNVi */
> we don't kw the default DSC value of CnviWifiCore/CnviBtCore/CnviBtAudioOffload hence, in case `s_cf […]

Ack

https://review.coreboot.org/c/coreboot/+/74370/comment/3ba4f217_dd39809d 
PS2, Line 568: 	if (!s_cfg->CnviMode && s_cfg->CnviWifiCore)
> IIRC why we do this before is this will cause FSP/kernel panic. So we put assert at first time. […]

Ack.

I did not see any issue in those cases but I've modified the code to be on safer side.