12 Jun
2023
12 Jun
'23
8:47 a.m.
Attention is currently required from: Angel Pons, Jason Glenesk, Julius Werner, Martin L Roth, Stefan Reinauer, Yu-Ping Wu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75707?usp=email )
Change subject: Rename CBFS master header -> CBFS main header ......................................................................
Patch Set 7: Code-Review-1
(1 comment)
Patchset:
PS7: sidenote: this structure is/should be deprecated.
Can the commit say why 'main' is more descriptive than 'master'? A lot of payloads still call this struct the cbfs master header. It's true that the name of the cbfs file is never used, but is this namechange really worth the confusion?
--
To view, visit https://review.coreboot.org/c/coreboot/+/75707?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I624da280dd78d707b96897b84768be5f5baf0770
Gerrit-Change-Number: 75707
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 06:47:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment