Attention is currently required from: Tarun Tuli, Subrata Banik, Eric Lai.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74380 )
Change subject: soc/intel/meteoerlake: set power limits dynamically ......................................................................
Patch Set 2:
(10 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74380/comment/2f9c4f49_63b5d7b2 PS1, Line 14: Rex board
Rex can only validate 15W SKU hence, other values are untested
I'll update this accordingly. Thanks.
Patchset:
PS1:
I think Intel can add other 45W/28W but with clear message like only verified 15W on Rex. […]
This above discussion makes more sense on not to add 28W/45W code at this stage. Let's add in future when it requires.
File src/soc/intel/meteorlake/chip.h:
https://review.coreboot.org/c/coreboot/+/74380/comment/1dafa6a5_0962738c PS1, Line 23: MTL_P_682_45W_CORE,
this is not POR for us, I would avoid adding it now to avoid the maintenance
Ack
https://review.coreboot.org/c/coreboot/+/74380/comment/a497ab5d_cd5a22ce PS1, Line 26: MTL_P_682_28W_CORE,
same
Done
https://review.coreboot.org/c/coreboot/+/74380/comment/e1128a51_d134a9b0 PS1, Line 33: TDP_28W = 28,
same
Done
https://review.coreboot.org/c/coreboot/+/74380/comment/ed6b16f8_e6e080ef PS1, Line 34: TDP_45W = 45
same
Done
https://review.coreboot.org/c/coreboot/+/74380/comment/9e1e6fe3_a355dce1 PS1, Line 43: { PCI_DID_INTEL_MTL_P_ID_1, MTL_P_682_45W_CORE, TDP_45W },
same
Done
https://review.coreboot.org/c/coreboot/+/74380/comment/5dec9192_17f6d829 PS1, Line 45: { PCI_DID_INTEL_MTL_P_ID_3, MTL_P_482_CORE, TDP_28W }, : { PCI_DID_INTEL_MTL_P_ID_4, MTL_P_682_28W_CORE, TDP_28W },
same
Done
File src/soc/intel/meteorlake/chipset.cb:
https://review.coreboot.org/c/coreboot/+/74380/comment/f1896880_02cc6db6 PS1, Line 12: register "power_limits_config[MTL_P_682_45W_CORE]" = "{ : .tdp_pl1_override = 45, : .tdp_pl2_override = 115, : .tdp_pl4 = 197, : }"
i don't even know if anyone is/will be using 45W part. […]
Ack
File src/soc/intel/meteorlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/74380/comment/be01841b_1e7186ad PS1, Line 174: for (i = 0; i < ARRAY_SIZE(cpuid_to_mtl); i++) {
We have plan to make this in common code later, already added in our TODO list.