Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48836 )
Change subject: cbfs: Fix attribute tag printing in cbfs_find_attr() ......................................................................
cbfs: Fix attribute tag printing in cbfs_find_attr()
Attribute tags are defined as hexadecimal constants, not decimal, so it makes more sense to print them like that in error messages as well.
Signed-off-by: Julius Werner jwerner@chromium.org Change-Id: I3a5a6a8c9b8d24e57633595fc47221a483d8593a Reviewed-on: https://review.coreboot.org/c/coreboot/+/48836 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/commonlib/bsd/cbfs_private.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/commonlib/bsd/cbfs_private.c b/src/commonlib/bsd/cbfs_private.c index 527860d..91f81e0 100644 --- a/src/commonlib/bsd/cbfs_private.c +++ b/src/commonlib/bsd/cbfs_private.c @@ -173,13 +173,13 @@ const uint32_t len = be32toh(attr->len);
if (offset + len > end) { - ERROR("Attribute %s[%u] overflows end of metadata\n", + ERROR("Attribute %s[%x] overflows end of metadata\n", mdata->h.filename, tag); return NULL; } if (tag == attr_tag) { if (size_check && len != size_check) { - ERROR("Attribute %s[%u] size mismatch: %u != %zu\n", + ERROR("Attribute %s[%x] size mismatch: %u != %zu\n", mdata->h.filename, tag, len, size_check); return NULL; }