Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44076 )
Change subject: soc/intel/common/block/cpu: Refactor init_cpus function ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44076/5/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/c/coreboot/+/44076/5/src/soc/intel/common/block/... PS5, Line 142: intel_microcode_load_unlocked
Why do you need to load Microcodes after FSP-S has done MPinit?
I believe we have checks inside "src/cpu/intel/microcode/microcode.c" as below to skip if ucode is already loaded. So calling is harmless
vim src/cpu/intel/microcode/microcode.c +59 /* No use loading the same revision. */ if (current_rev == m->rev) { printk(BIOS_INFO, "microcode: Update skipped, already up-to-date\n"); return; }
And from log, i could see it skipping the same.
microcode: Update skipped, already up-to-date