Attention is currently required from: Hung-Te Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85665?usp=email )
Change subject: soc/mediatek: Add support for MediaTek firmware support package ......................................................................
Patch Set 2: Code-Review+1
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85665/comment/3313d302_99610e69?usp... : PS2, Line 10: firmeware firmware
https://review.coreboot.org/c/coreboot/+/85665/comment/1455753a_bdd1e006?usp... : PS2, Line 11: includes include
File src/soc/mediatek/common/mtk_fsp.c:
https://review.coreboot.org/c/coreboot/+/85665/comment/f7c217d1_f4fc7e7b?usp... : PS2, Line 19: void `enum fsp_phase phase`
https://review.coreboot.org/c/coreboot/+/85665/comment/5d93ed68_08654e01?usp... : PS2, Line 36: mtk_fsp_init(); I think we should return an error here. If `mtk_fsp_init` is in the API, the caller should call it before calling other functions.
https://review.coreboot.org/c/coreboot/+/85665/comment/5cc95da8_495b4f11?usp... : PS2, Line 89: mtk_fsp_init(); I think we should return an error here. If `mtk_fsp_init` is in the API, the caller should call it before calling other functions.
https://review.coreboot.org/c/coreboot/+/85665/comment/3c314463_a40218d8?usp... : PS2, Line 92: prog_set_entry(&fsp, prog_entry(&fsp), intf); `prog_set_arg(&fsp, intf)`. Otherwise you're just setting `prog->entry` to `prog->entry`.
https://review.coreboot.org/c/coreboot/+/85665/comment/5464368d_198e1a1c?usp... : PS2, Line 100: d #x