Attention is currently required from: Felix Held, Felix Singer, Martin L Roth, Nicholas Chin, Nicholas Sudsgaard, Paul Menzel.
KunYi Chen has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )
Change subject: mb/lattepanda: Add support for LattePanda Mu ......................................................................
Patch Set 12:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83719/comment/53c177fd_4b7d8155?usp... : PS8, Line 2: KunYi
I see. It’s uncommon in “Western” sphere, to have CamelCase names. Often a space or hyphen is used.
Thank you for your suggestion. I initially used CamelCase just to distinguish between different words. I'll keep this in mind for the future. Thanks again.
Commit Message:
https://review.coreboot.org/c/coreboot/+/83719/comment/0c251718_58ffeb74?usp... : PS12, Line 20: Testing with Lite carrier board
Please also list the payload (and version).
Acknowledged, okay, the payload is default setting mrchromebox/edk2 uefipayload_202309
File src/mainboard/lattepanda/mu/board_info.txt:
https://review.coreboot.org/c/coreboot/+/83719/comment/fcc4fad9_ed4f7c67?usp... : PS12, Line 1: Vendor name: DFRobot
Hmm, should the directory have the vendor included then? […]
DFRobot uses 'LattePanda' as the brand for SBC/DevKit, so I think it's better to use LattePanda like this.
please visit https://www.lattepanda.com/
File src/mainboard/lattepanda/mu/data.vbt:
PS12:
Please mention in the commit message, how you created this file.
Acknowledged, okay I use UEFITool to extract it.