Attention is currently required from: Felix Held, KunYi Chen, Nicholas Chin, Nicholas Sudsgaard.
Paul Menzel has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )
Change subject: mb/lattepanda: Add support for LattePanda Mu ......................................................................
Patch Set 21:
(2 comments)
File src/mainboard/lattepanda/mu/bootblock.c:
https://review.coreboot.org/c/coreboot/+/83719/comment/45bf786d_b0e6565a?usp... : PS21, Line 20: /* : * IT8613E Super I/O Chip Initialization Settings : * : * Source: IT8728FPeiInit module : * Purpose: Configure the IT8613E Super I/O chip during system startup : * : * Analysis Process: : * 1. Extract the 'IT8728FPeiInit' module from the original BIOS : * using UEFITool NE alpha 68 (Nov 4 2023). : * 2. Load the extracted module into Ghidra v11.1.2 for disassembly and analysis : * 3. Identify and document the initialization settings from the disassembled code : * : */ Disassembling and reverse engineering are illegal in some jurisdictions. Better remove it.
https://review.coreboot.org/c/coreboot/+/83719/comment/4a80b06e_843baf6c?usp... : PS21, Line 96: static void it8613e_init(const u16 p_idx, const u16 p_dat, const struct initdata *table, const size_t count) : { : u8 val; : : for (size_t i = 0; i < count; i++) { : outb(table[i].reg, p_idx); : : if (table[i].OpAnd == 0) { : val = table[i].OpOr; : } else { : val = ((inb(p_dat) & table[i].OpAnd) | : table[i].OpOr); : } : : outb(val, p_dat); : } : } Is it possible to do this in the Super I/O code (`src/superio/ite/it8613e/`)? This could be done later I guess.