Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44429 )
Change subject: util: Add spd_tools to generate DDR4 SPDs for TGL boards
......................................................................
Patch Set 29:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44429/29/util/spd_tools/intel/ddr4/...
File util/spd_tools/intel/ddr4/gen_part_id.go:
PS29:
We should drop "intel" from the path i.e. move util/spd_tools/intel/ddr4 to util/spd_tools/ddr4. Same for lp4x.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44429
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I263f936b332520753a6791c8d892fc148cb6f103
Gerrit-Change-Number: 44429
Gerrit-PatchSet: 29
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Aug 2020 22:40:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment