12 Sep
2019
12 Sep
'19
1:21 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35365 )
Change subject: emulation/qemu-i440fx: use fw_cfg_dma for fw_cfg_read ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35365/2/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/c/coreboot/+/35365/2/src/mainboard/emulation/qem... PS2, Line 529: dma_desc_addr = (uint32_t)&dma; that doesn't work on x86_64. Please write FW_CFG_DMA_ADDR_HIGH as well.
https://review.coreboot.org/c/coreboot/+/35365/2/src/mainboard/emulation/qem... PS2, Line 532: asm(""); should work without asm("").
--
To view, visit https://review.coreboot.org/c/coreboot/+/35365
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0be5355b124af40aba62c0840790d46ed0fe80a2
Gerrit-Change-Number: 35365
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1002476
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Thu, 12 Sep 2019 08:21:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment