Attention is currently required from: Jonathan Zhang, Johnny Lin, Paul Menzel, Martin Roth.
Ed Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68637 )
Change subject: commonlib/fsp_relocate: Fix Coverity Issues ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68637/comment/8a5da800_8261b938 PS1, Line 9: Recently committed change 1df1cf9 resulted in some Coverity
Instead of "https://review.coreboot. […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/68637/comment/1eda071d_e184ddca PS2, Line 7: commonlib/fsp_relocate: Fix Coverity Issues
For the summary/title it’s not important what tool found an issue. […]
Ack
https://review.coreboot.org/c/coreboot/+/68637/comment/a422ebe3_60b07d4f PS2, Line 9: Recently committed change 1df1cf9 resulted in some Coverity : reported issues. This change attempts to fix the static : analysis issues reported. The issues were reported as : comments in https://review.coreboot.org/c/coreboot/+/66819 : I have looked at all Coverity fixes before my change using : git log --oneline | grep -i coverity and then detailed : git diffs for all coverity changes. However none of them : had the same coverity errors reported as were reported : for my changes. I do not have the manner to run coverity : on my own to test my changes against coverity tests. : : TESTED= : This code is tested with Intel CooperLake-SP FSP version : 2.2.0.33A for DeltaLake boot
Please reflow for 72 characters per line.
Done