Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43419 )
Change subject: util/mb/google: add template files for dalboz and trembyle ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43419/4/util/mainboard/google/dalbo... File util/mainboard/google/dalboz/template/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43419/4/util/mainboard/google/dalbo... PS4, Line 37: device pci 8.1 on # Internal GPP Bridge 0 to Bus A : device pci 0.3 on end # USB 3.1 : end
Can remove this too.
Done
https://review.coreboot.org/c/coreboot/+/43419/4/util/mainboard/google/tremb... File util/mainboard/google/trembyle/template/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43419/4/util/mainboard/google/tremb... PS4, Line 29: .rise_time_ns = 21, /* 0 to 2.31 (3.3 * .7) */ : .fall_time_ns = 76, /* 2.31 to 0 */
Clear these for both
Done
https://review.coreboot.org/c/coreboot/+/43419/4/util/mainboard/google/tremb... PS4, Line 46: device pci 8.1 on # Internal GPP Bridge 0 to Bus A : device pci 0.3 on end # USB 3.1 : device pci 0.4 on end # USB 3.1 : end
Think Rob is getting rid of these.
Done