Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: src/device/oprom: Fix bootsplash display code for optionroms ......................................................................
Patch Set 15:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34537/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34537/15//COMMIT_MSG@10 PS15, Line 10: setup The verb is spelled with a space: set up. (You can think on where the third person s would go: he/she/it sets up the table ….
https://review.coreboot.org/c/coreboot/+/34537/15//COMMIT_MSG@15 PS15, Line 15: For the moment the bootsplash is still limited to VGA-OptionROM framebuffer init. Just for my memory, what happens if the bootsplash image has different dimensions? Is it cropped or put on the top left side?
https://review.coreboot.org/c/coreboot/+/34537/15//COMMIT_MSG@16 PS15, Line 16: Please document how you tested this.
https://review.coreboot.org/c/coreboot/+/34537/15/src/device/oprom/realmode/... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/34537/15/src/device/oprom/realmode/... PS15, Line 354: For the future, please do clean-ups in separate commits.
https://review.coreboot.org/c/coreboot/+/34537/15/src/lib/bootsplash.h File src/lib/bootsplash.h:
https://review.coreboot.org/c/coreboot/+/34537/15/src/lib/bootsplash.h@20 PS15, Line 20: * Returns 0 on success The return type is void currently. Is that wanted?