Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver
......................................................................
Patch Set 20:
(2 comments)
File src/soc/mediatek/common/include/soc/mt6363_sdmadc.h:
https://review.coreboot.org/c/coreboot/+/85128/comment/7315b9a7_51a516c0?usp... :
PS18, Line 10:
tab
Done
File src/soc/mediatek/common/mt6363_sdmadc.c:
https://review.coreboot.org/c/coreboot/+/85128/comment/c7b73acc_67403e50?usp... :
PS17, Line 76:
Add […]
Just calling mt6363_init_pmif_arb is enough, no need mt6363_init.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85128?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice3c286cd207e445392d5f0126a07ce4f40dcf8a
Gerrit-Change-Number: 85128
Gerrit-PatchSet: 20
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 06 Dec 2024 11:38:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com