Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25372 )
Change subject: sdm845: Add QUPv3 FW load & config ......................................................................
Patch Set 78:
(1 comment)
https://review.coreboot.org/c/coreboot/+/25372/6/src/mainboard/google/cheza/... File src/mainboard/google/cheza/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/25372/6/src/mainboard/google/cheza/... PS6, Line 18: struct se_cfg se_mappings[QUPV3_SE_MAX] =
Since coreboot is a single-threaded environment, loading of FW dynamically from respective protocol init function seems to be technically possible.
Great, let's do it!
To lock FW content we need to write to registers 1) se_geni_fw_multilock_msa 2) se_geni_fw_multilock_protns that is possible only from the secured environment.
I would suggest we just do this at the end of coreboot's ramstage (e.g. from soc.c), after we are sure that we have loaded all the QUPs we'll need.
We have a few more queries regarding the usage of the above features(dynamic loadability of FW) and scenarios.
I feel it's better to discuss it on call, can we setup a meeting for it?
If you can make it in a US friendly time (12pm-6pm PDT) we can set something up -- just send me an email with some times that work for you. Otherwise, maybe we can try to see how far we get discussing it via email first?