Attention is currently required from: Julius Werner, Martin L Roth, Nico Huber.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84431?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: sconfig: Move config_of_soc from device.h to static.h ......................................................................
Patch Set 2:
(1 comment)
File src/include/device/devicetree.h:
PS1:
Actually, there may be a technical argument: We could even safe us further […]
Thinking about it, an I do like the idea of putting the extern in device.h. Most of the files that currently rely on static.h use `config_of_soc`, and the current patchset would mean I would need to add static.h to a lot of files before dropping the header from device.h. The rest of the files that need static.h directly reference devices in static_device.h which would be less work.
If I put the extern declaration in device.h, I get a duplicate declaration if I leave static.h included, so I think that would mean all the explicit static.h includes throughout the tree would need to be fixed before or at the same time as as adding the extern declaration to device.h
I'll think about the various options for a bit.