Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42205 )
Change subject: mb/google/dedede: Add ACPI support for camera in WDee
......................................................................
Patch Set 19:
(1 comment)
Could someone also share a dump of the final DSDT table that is generated from this?
https://review.coreboot.org/c/coreboot/+/42205/19/src/mainboard/google/deded...
File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42205/19/src/mainboard/google/deded...
PS19, Line 197: register "pr0" = ""\_SB.PCI0.I2C3.CAM1.PRIC""
In general we shouldn't need to power on the sensor to access the EEPROM. Might not be a problem for this one, since this is rear-facing and might not have a privacy LED (for someone to check), but in general it would cause the LED to blink which isn't acceptable because of user concerns.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f6b490832d2c34c86512384eb7470f13a212a66
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 19
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andy Yeh
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kaiyen Chang
kaiyen.chang@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-CC: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-CC: Tomasz Figa
tfiga@google.com
Gerrit-Comment-Date: Wed, 09 Sep 2020 21:52:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment