[coreboot-gerrit] [L] Change in coreboot[master]: mb/inventec: Add Intel SPR server board Inventec Transformers

[David Hendricks (Code Review)]

Attention is currently required from: Angel Pons, Annie Chen, Arthur Heymans, Felix Singer, Hung-Wei Chen, Jonathan Zhang, Lean Sheng Tan, Paul Menzel.

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75598?usp=email )

Change subject: mb/inventec: Add Intel SPR server board Inventec Transformers
......................................................................

Patch Set 6:

(1 comment)

Patchset:

PS5:
> Done

Hi Felix,
I'm working on making this into a variant of Archer City now. You're correct that a substantial amount of code is shared with the Archer City CRB, however there are a couple of additions in GPIO assignment, IPMI commands, and SMBIOS info.

Is there a particular example of a variant you think might be useful here? One important difference is that with server products we do not expect a single hardware configuration; we expect differences in things like max sockets, PCIe bifurcation/lane config, BMC commands (due to different BMC firmwares out there and OEM-specific commands), and GPIO assignments.

So the baseboard Makefile.inc and Kconfig might not be as pretty in our case, but it may still be a good tradeoff to reduce duplicated code.