EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41712 )
Change subject: soc/intel/common: Add restore and enable GPIO PM ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
I nailed the GPIO communities mapping. Please provide ideas if any.. I verified at my Deltan.
Instead can you check with below changes + patch set 1(is deltan not using MS0x?) on TGL? I checked below on JSL and verified it working. https://review.coreboot.org/c/coreboot/+/41721
Case (0) {
Case (COMM_0) { Local0 = PID_GPIOCOM0 }
Case (1) {
Case (COMM_1) { Local0 = PID_GPIOCOM1 }
Case (2) {
Case (COMM_2) { Local0 = PID_GPIOCOM2 }
Case (4) {
Case (COMM_4) { Local0 = PID_GPIOCOM4 }
Case (5) {
Case (COMM_5) { Local0 = PID_GPIOCOM5
This is way is good... I can go back to patch 1, I did in CML. I already hooked the EGPM in the lpit.asl and platform.asl you don't need the board level hook...