Cheng-Yi Chiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36028 )
Change subject: google/chromeos: Add a library to get DSM calibration data ......................................................................
Patch Set 11:
(2 comments)
Thanks for reviewing!
https://review.coreboot.org/c/coreboot/+/36028/9/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/chromeos.h:
https://review.coreboot.org/c/coreboot/+/36028/9/src/vendorcode/google/chrom... PS9, Line 62: #if CONFIG(CHROMEOS_DSM_CALIB)
I know this is common in this file, but it should be okay not to guard this declaration.
Done
https://review.coreboot.org/c/coreboot/+/36028/9/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/dsm_calib.c:
https://review.coreboot.org/c/coreboot/+/36028/9/src/vendorcode/google/chrom... PS9, Line 44: value_from_vpd < 0)
Is it expected that some calibration parameters could be 0? If they are resistor values and tempera […]
Thanks for catching this. Yes these values are expected to be greater than 0. In the factory these values were checked before writing to VPD. If somehow a non-positive value is calibrated, it will fail the calibration step and that device will not be shipped until being resolved. But it is better we put a check here as well.