Attention is currently required from: Kapil Porwal, Subrata Banik, Sukumar Ghorai, Tarun Tuli.
Hello Kapil Porwal, Sukumar Ghorai, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75822?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by Sukumar Ghorai, Verified+1 by build bot (Jenkins)
Change subject: soc/intel/meteorlake: Disable ACPI PM timer using IOE.PMC ......................................................................
soc/intel/meteorlake: Disable ACPI PM timer using IOE.PMC
This patch disables the ACPI PM timer which is necessary for XTAL OSC shutdown. Also, disabling ACPI PM timer switches off TCO.
BUG=b:274744845 TEST=Able to boot and verify S0ix is working even with EC reset and cold boot scenarios.
w/o this cl:
iotools mmio_read32 0xfe4018fc
0x0
w/ this cl:
iotools mmio_read32 0xfe4018fc
0x2
Change-Id: Ibb6e145f67dba7270e0a322ef414bf1cb09c5eda Signed-off-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/meteorlake/include/soc/iomap.h M src/soc/intel/meteorlake/include/soc/pm.h M src/soc/intel/meteorlake/pmc.c M src/soc/intel/meteorlake/pmutil.c 4 files changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/75822/2