Attention is currently required from: Keith Hui, Branden Waldner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59766 )
Change subject: [Untested]cpu/x86/mp.h: Implement a pre-SSE2 mfence ......................................................................
Patch Set 2:
(3 comments)
File src/include/cpu/x86/mp.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134688): https://review.coreboot.org/c/coreboot/+/59766/comment/b450ede3_e7660063 PS2, Line 18: __asm__ __volatile__("mfence\t\n": : :"memory"); spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134688): https://review.coreboot.org/c/coreboot/+/59766/comment/ea263b2d_2b11590e PS2, Line 18: __asm__ __volatile__("mfence\t\n": : :"memory"); spaces required around that ':' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134688): https://review.coreboot.org/c/coreboot/+/59766/comment/eecb7d07_1540b319 PS2, Line 20: __asm__ __volatile__("lock; addl $0,0(%%esp)": : : "memory"); spaces required around that ':' (ctx:VxW)