Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39345 )
Change subject: mb/google/volteer: Enable DPTF functionality
......................................................................
Patch Set 4:
(1 comment)
can you also create patch for TGLRVP?
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee...
PS3, Line 151: Device4Enable
This is for enabling TCPU as thermal zone.
There is no fsp param setting in soc folder.
src/soc/intel/tigerlake/fsp_params_tgl.c:
You need to add fsp param setting to enable this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccd387d78bb45ca3de73f531a901d1d3f793d7bd
Gerrit-Change-Number: 39345
Gerrit-PatchSet: 4
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Tue, 17 Mar 2020 19:33:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment