Meng-Huan Yu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48113 )
Change subject: libpayload: Provide API to expose MMU memery ranges for ARM64 ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48113/4/payloads/libpayload/include... File payloads/libpayload/include/arm64/arch/mmu.h:
https://review.coreboot.org/c/coreboot/+/48113/4/payloads/libpayload/include... PS4, Line 199: includes
include
Done
https://review.coreboot.org/c/coreboot/+/48113/4/payloads/libpayload/include... PS4, Line 202: mmu_get_ranges
How about mmu_get_used_ranges? Otherwise, please at least mention "used" in the function comment.
I feel the term "used" is a little bit ambiguous here. Do you mean a) it is a "valid" memory range or b) it is a "occupied" by someone?
For me, the ranges for MMU (mmu_get_ranges()) sounds like getting the mapped memory regions. The normal DRAM range will be mapped and stored in the structure, but they may be considered as "free" (can be used) memory in the perspective of payloads.
I update the comment message to describe more detail and give more examples. What do you think about this version?