Tim Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35768 )
Change subject: mb/google/octopus: Create Dood variant ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35768/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/dood/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/35768/2/src/mainboard/google/octopu... PS2, Line 22: #define EC_ENABLE_KEYBOARD_BACKLIGHT
Will Dood need keyboard backlight?
After checking Dood does not support keyboard backlight, so remove it.
https://review.coreboot.org/c/coreboot/+/35768/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/dood/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35768/2/src/mainboard/google/octopu... PS2, Line 55: #| I2C7 | Touchscreen |
Dood is clamshell so we don't need I2C0 and I2C7?
Checking with our PM Dood is Yoga(360 degree) so it needs touchscreen but does not support digitizer and pen. Thank you.
https://review.coreboot.org/c/coreboot/+/35768/2/src/mainboard/google/octopu... PS2, Line 110: end
And pen?
remove digitizer and pen.