[coreboot-gerrit] Change in coreboot[master]: lib/edid_fill_fb: Support multiple framebuffers

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )

Change subject: lib/edid_fill_fb: Support multiple framebuffers
......................................................................

Patch Set 21: Code-Review+1

(5 comments)

https://review.coreboot.org/c/coreboot/+/39002/21//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39002/21//COMMIT_MSG@17 
PS21, Line 17: the advertisement
             : of
advertise

https://review.coreboot.org/c/coreboot/+/39002/21/src/include/framebuffer_in... 
File src/include/framebuffer_info.h:

https://review.coreboot.org/c/coreboot/+/39002/21/src/include/framebuffer_in... 
PS21, Line 2: /* This file is part of the coreboot project. */
Please drop

https://review.coreboot.org/c/coreboot/+/39002/7/src/lib/edid_fill_fb.c 
File src/lib/edid_fill_fb.c:

https://review.coreboot.org/c/coreboot/+/39002/7/src/lib/edid_fill_fb.c@63 
PS7, Line 63: 				 uint8_t blue_mask_size)
> Any updates?

Latest patchset passes in a pointer to `struct lb_framebuffer`

https://review.coreboot.org/c/coreboot/+/39002/21/src/lib/edid_fill_fb.c 
File src/lib/edid_fill_fb.c:

https://review.coreboot.org/c/coreboot/+/39002/21/src/lib/edid_fill_fb.c@96 
PS21, Line 96: physical_address    : fb_addr,
This is the old syntax for struct initializers. New syntax would be:

.physical_address    = fb_addr,

https://review.coreboot.org/c/coreboot/+/39002/21/src/lib/edid_fill_fb.c@105 
PS21, Line 105: 0
Is this supposed to be the same as `red_mask_pos` ?