Attention is currently required from: Paul Menzel, Mario Scheithauer, Jan Samek.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74628 )
Change subject: mb/siemens/mc_ehl4: Adjust GPIOs
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/mainboard/siemens/mc_ehl/variants/mc_ehl4/gpio.c:
https://review.coreboot.org/c/coreboot/+/74628/comment/88365956_a27130f9
PS4, Line 64: PAD_CFG_NF(GPP_H8, UP_20K, DEEP, NF1), /* SIO_I2C4_SDA */
: PAD_CFG_NF(GPP_H9, UP_20K, DEEP, NF1), /* SIO_I2C4_SCL */
I have included both GPIOs again. But in this case, FSP would also set them to NF1, since device 19. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74628
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66bfbb380e9a05b3a2c08d5d1980e9749b46ee43
Gerrit-Change-Number: 74628
Gerrit-PatchSet: 5
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Jan Samek
jan.samek@siemens.com
Gerrit-Comment-Date: Tue, 25 Apr 2023 07:56:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment