Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Angel Pons, Aamir Bohra, Felix Held. ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60968 )
Change subject: soc/amd/common/block/psp: Add platform secure boot support ......................................................................
Patch Set 9:
(6 comments)
File src/soc/amd/common/block/psp/Kconfig:
https://review.coreboot.org/c/coreboot/+/60968/comment/b5ad4a76_8603733d PS5, Line 33: default n
can be dropped I believe, default in n.
doesn't hurt to explicitly set default n.
File src/soc/amd/common/block/psp/Kconfig:
https://review.coreboot.org/c/coreboot/+/60968/comment/a11d96c3_68be8900 PS9, Line 35: item
config
Ack
File src/soc/amd/common/block/psp/psb.c:
https://review.coreboot.org/c/coreboot/+/60968/comment/88c301aa_df19d0da PS9, Line 96: #define FUSE_STATUS_NOT_ALLOWED 0x09 : #define FUSE_STATUS_FUSING_ERR 0x0a : #define FUSE_STATUS_BOOT_DONE 0x0b
these are used in fuse_status_to_string().
Ack
https://review.coreboot.org/c/coreboot/+/60968/comment/3ce9a946_146de3d1 PS9, Line 96: #define FUSE_STATUS_NOT_ALLOWED 0x09 : #define FUSE_STATUS_FUSING_ERR 0x0a : #define FUSE_STATUS_BOOT_DONE 0x0b
these are used in fuse_status_to_string().
Ack
https://review.coreboot.org/c/coreboot/+/60968/comment/e64e20d4_7a38fd54 PS9, Line 187:
extra space is added to split of printk line.
Ack
https://review.coreboot.org/c/coreboot/+/60968/comment/84b5d04f_429f7de5 PS9, Line 210:
extra space is added to split of printk line.
Ack